build: Simplify python discovery at configure time #3990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
If the desired python command is newer than the ones known by aclocal,
we can use the PYTHON variable to select it:
./configure PYTHON=python3.11
This already worked before this change, but now we stop chasing python
releases to get them automatically tested.
Refs varnishcache#3982
dridi
force-pushed
the
configure_python
branch
from
2649c97
to
e1e229b
Compare
catap
reviewed
Sep 26, 2023
| AC_MSG_ERROR([Python >= 3.4 is required.]) | ||
| ]) | ||
|
|
||
| AM_PATH_PYTHON([3.4], [], [AC_MSG_ERROR([Python >= 3.4 is required.])]) |
There was a problem hiding this comment.
Suggested change
| AM_PATH_PYTHON([3.4], [], [AC_MSG_ERROR([Python >= 3.4 is required.])]) | |
| AM_PATH_PYTHON([3.4], [], [AC_MSG_ERROR([Python >= 3.4 is required. You may define used python via PYTHON=/path/to/python option at ./configure])]) |
There was a problem hiding this comment.
Not sure that it worth it, but might help someone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the desired python command is newer than the ones known by aclocal, we can use the PYTHON variable to select it:
This already worked before this change, but now we stop chasing python releases to get them automatically tested.
Refs #3982
Keeping as a draft for the moment, considering to hold it until we know the next major version (7.5.0 or 8.0.0) to make sure we don't forget to update the serial.