Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #168 - make Variety work with mongosh #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CodyDWJones
Copy link

It seems a JS script can no longer check if mongosh was started with the --quiet flag, so this commit changes Variety to be always verbose.

A quiet config option could be added that would be distinct from the CLI's own --quiet, though the circular dependency between log() and readConfig.read() would need to be broken.

It seems a JS script can no longer check if mongosh was started with
the --quiet flag, so this commit changes Variety to be always
verbose.

A "quiet" config option could be added that would be distinct from
the CLI's own --quiet, though the circular dependency between log()
and readConfig.read() would need to be broken.
Copy link

@unitysipu unitysipu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add a feature to autodetect mongosh and use that automatically, i think currently this requires the user to create a symbolic link to mongosh manually and the error message isn't super informative of the fact.

@JamesCropcho
Copy link
Member

Greetings, @CodyDWJones and @unitysipu !

To write here what I'd written elsewhere a little while ago:

I'm thrilled that Variety continues to be used and to have a community. I do admit that the project is need of some serious love by me and/or others—not necessarily to add features but even simply to modernize it, i.e. 1) make it work with recent versions of things; and 2) ensure that the dependencies lack published security exploits/warnings.


And yes, that is still accurate, alas. I haven't been yet able to look at this PR nor #168 but certainly, this is a needed upgrade.

Ever since TravisCI went away we really haven't had a sufficiently good CI nor automated-testing infrastructure. I imagine that I'll/we'll need to get something like that together before we can rightfully merge any substantial pull requests.

―James

@javespi
Copy link

javespi commented Apr 26, 2024

Ty @CodyDWJones for the PR

Thanks to your fork I was able to get schemas in a Mongo 7 database 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants