fix: bottom view line in overview is now calculated correctly. #707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when viewing files, the "view lines" shown on the overview did not line up with the actual lines that were being viewed. Instead, one of the lines would always remain near the top of the file.
This is because this change added some extra brackets to
Overview::getViewLines()
that changed the order of operations in the calculation ofbottom
. I've fixed up the order of operations for this calculation.Original working code:
bottom = (int)((qint64)top + nbLines_.get() * height_ / linesInFile_.get());
Code with incorrect order of operations:
bottom = static_cast<int>( ( static_cast<unsigned>( top ) + nbLines_.get() ) * height_ / ( linesInFile_.get() ) );
Fixed code:
bottom = top + static_cast<int>( nbLines_.get() * height_ / ( linesInFile_.get() ) );