Fix issue #163 duplicate boundaries

vaquerizaslab · Aug 17, 2023 · 68cb7ae · 68cb7ae
1 parent 8e6f77f
commit 68cb7ae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -4,6 +4,7 @@
 - Fixed issue #136 that prevented the use of -r parameter in fanc insulation
 - Added option to ignore sambamba when using sam_sort or auto
 - Fixed an issue with Juicer fieles when normalisation info is missing
+- Fix issue #163 where boundaries might be reported multiple times in rare cases
 
 0.9.25
 

diff --git a/fanc/architecture/domains.py b/fanc/architecture/domains.py
@@ -609,7 +609,6 @@ def from_insulation_score(cls, insulation_score, window_size=None,
             minima, scores = peaks.get_maxima()
         else:
             minima, scores = peaks.get_minima()
-        #regions = list(insulation_score.regions)
 
         boundaries = []
         for i, ix in enumerate(minima):

diff --git a/fanc/architecture/maxima_callers.py b/fanc/architecture/maxima_callers.py
@@ -14,7 +14,9 @@ def find_zero_crossing(x, sub_bin_precision=False):
     frac = left/(left - right)
     if sub_bin_precision:
         return idx + frac
-    return np.rint(idx + frac).astype(np.int_)
+    zero_crossings = np.rint(idx + frac).astype(np.int_)
+
+    return np.unique(zero_crossings)
 
 
 def getitem_interpolated(array, idx):