Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Implement of promise for filter function; #1105

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

duykhang53
Copy link

File filter function from this commit now can be resolved from both boolean and Promise<boolean>

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #1105 into development will increase coverage by 0.19%.
The diff coverage is 28.94%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1105      +/-   ##
===============================================
+ Coverage        34.72%   34.91%   +0.19%     
===============================================
  Files               10       10              
  Lines              550      547       -3     
  Branches            80       83       +3     
===============================================
  Hits               191      191              
+ Misses             341      336       -5     
- Partials            18       20       +2
Impacted Files Coverage Δ
src/file-upload/file-uploader.class.ts 24.63% <11.53%> (+0.44%) ⬆️
src/file-upload/file-drop.directive.ts 60% <62.5%> (-1.23%) ⬇️
src/file-upload/file-select.directive.ts 73.91% <75%> (-3.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb48f44...1e5fb25. Read the comment docs.

@angus151
Copy link

Can we get this pulled?

@duykhang53
Copy link
Author

Yea sure

@angus151
Copy link

Yea sure

Sorry, comment wasn't direct at you, but to hopefully catch the eye of one of the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants