Use different E-Mail regex #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in valiktor#57, the current Regex is broken for Emails like: ``` foo.bar+mysuffix@gmail.com ``` Therefore, exchange the used regex with the one from emailregex.com.
| @@ -479,7 +479,8 @@ fun <E> Validator<E>.Property<String?>.doesNotEndWithIgnoringCase(suffix: String | |||
| fun <E> Validator<E>.Property<String?>.isEmail(): Validator<E>.Property<String?> = | |||
| this.validate(Email) { | |||
| it == null || it.matches( | |||
| Regex("^[_A-Za-z0-9-\\+]+(\\.[_A-Za-z0-9-]+)*@[A-Za-z0-9-]+(\\.[A-Za-z0-9]+)*(\\.[A-Za-z]{2,})$") | |||
| // see https://emailregex.com/ | |||
There was a problem hiding this comment.
I think we dont need to keep this comment
There was a problem hiding this comment.
I think the comment is pretty important, because it's easier to go to emailregex.com and read the documentation of the Regex instead of trying to figure out if the given regex makes sense 😉
| @@ -479,7 +479,8 @@ fun <E> Validator<E>.Property<String?>.doesNotEndWithIgnoringCase(suffix: String | |||
| fun <E> Validator<E>.Property<String?>.isEmail(): Validator<E>.Property<String?> = | |||
| this.validate(Email) { | |||
| it == null || it.matches( | |||
| Regex("^[_A-Za-z0-9-\\+]+(\\.[_A-Za-z0-9-]+)*@[A-Za-z0-9-]+(\\.[A-Za-z0-9]+)*(\\.[A-Za-z]{2,})$") | |||
| // see https://emailregex.com/ | |||
| Regex("""(?:[a-z0-9!#${'$'}%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#${'$'}%&'*+/=?^_`{|}~-]+)*|"(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21\x23-\x5b\x5d-\x7f]|\\[\x01-\x09\x0b\x0c\x0e-\x7f])*")@(?:(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?|\[(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?|[a-z0-9-]*[a-z0-9]:(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21-\x5a\x53-\x7f]|\\[\x01-\x09\x0b\x0c\x0e-\x7f])+)\])""") | |||
There was a problem hiding this comment.
${'$'} is this necessary? cant we just scape the $ character?
There was a problem hiding this comment.
Not sure anymore, this pr is already pretty old and to be honest we have moved on and I don't care too much about this anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #57, the current Regex is broken for Emails like:
Therefore, exchange the used regex with the one from emailregex.com.