Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/map with is in #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/map with is in #46

wants to merge 2 commits into from

Conversation

knmsk
Copy link

@knmsk knmsk commented Jul 2, 2020

Fixes #45

Proposed Changes

  • Added isInKeys, isNotInKeys, isNotInValues and isInValues

rogerio-kino-ifood and others added 2 commits July 2, 2020 17:29
@knmsk knmsk closed this Jul 2, 2020
@knmsk knmsk reopened this Jul 3, 2020
@gabrielerzinger
Copy link

gabrielerzinger commented Apr 16, 2021

Hello @kino-massaki, I don't know if I followed the idea here, however, wouldn't it be better to name it as

containsKeys
notContainsKeys

and the correspondent ones to values?

Other than the names, I think this would be a great contribution

@knmsk
Copy link
Author

knmsk commented Apr 20, 2021

@gabrielerzinger the idea here is to cover the other logic that the isInKeys or isNotInKeys could not. The methods can be renamed to containsKeys and notContainsKeys and i think maybe is better to refactor the class to match the same pattern.

@gabrielerzinger
Copy link

@kino-massaki cool, would you be willing to do that?

@rodolphocouto if you could share your opinion on that matter

@knmsk
Copy link
Author

knmsk commented Jun 17, 2021

@gabrielerzinger actually containsKey and notContainsKey already exists, i think taht it should stay the same as is, to match the function for iterables and array.
@rodolphocouto any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add isIn and isNotIn on Map validation
2 participants