added new validation if property is UUID #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @see Constraint | ||
| * @since 0.1.0 | ||
| */ | ||
| object IsUUID : Constraint |
There was a problem hiding this comment.
This constraint must be applied only for String properties, so it should be moved to the file TextConstraints.kt. BTW, I think UUID is a better name.
| * @return the same receiver property | ||
| */ | ||
| fun <E> Validator<E>.Property<String?>.isUUID(): Validator<E>.Property<String?> = | ||
| this.validate(IsUUID) { it == null || it.matches(Regex("^[0-9a-f]{8}-[0-9a-f]{4}-[0-5][0-9a-f]{3}-[089ab][0-9a-f]{3}-[0-9a-f]{12}$")) } |
There was a problem hiding this comment.
This function must be moved to the file StringFunctions.kt.
| @@ -6,6 +6,7 @@ org.valiktor.constraints.NotEquals.message=Must not be equal to {value} | |||
| org.valiktor.constraints.In.message=Must be in {values} | |||
| org.valiktor.constraints.NotIn.message=Must not be in {values} | |||
| org.valiktor.constraints.Valid.message=Must be valid | |||
| org.valiktor.constraints.IsUUID.message=Not a valid identifier (uuid) | |||
There was a problem hiding this comment.
Suggested change
| org.valiktor.constraints.IsUUID.message=Not a valid identifier (uuid) | |
| org.valiktor.constraints.UUID.message=Must be a valid UUID |
| @@ -6,6 +6,7 @@ org.valiktor.constraints.NotEquals.message=No pot ser igual a {value} | |||
| org.valiktor.constraints.In.message=Ha de ser un dels seg\u00FCents: {values} | |||
| org.valiktor.constraints.NotIn.message=No pot ser un dels seg\u00FCents: {values} | |||
| org.valiktor.constraints.Valid.message=Ha de ser v\u00E0lid | |||
| org.valiktor.constraints.IsUUID.message=No \u00E9s un identificador v\u00E0lid (uuid) | |||
There was a problem hiding this comment.
Suggested change
| org.valiktor.constraints.IsUUID.message=No \u00E9s un identificador v\u00E0lid (uuid) | |
| org.valiktor.constraints.UUID.message=Ha de ser un UUID vàlid |
| @@ -6,6 +6,7 @@ org.valiktor.constraints.NotEquals.message=Must not be equal to {value} | |||
| org.valiktor.constraints.In.message=Must be in {values} | |||
| org.valiktor.constraints.NotIn.message=Must not be in {values} | |||
| org.valiktor.constraints.Valid.message=Must be valid | |||
| org.valiktor.constraints.IsUUID.message=Not a valid identifier (uuid) | |||
There was a problem hiding this comment.
Suggested change
| org.valiktor.constraints.IsUUID.message=Not a valid identifier (uuid) | |
| org.valiktor.constraints.UUID.message=Must be a valid UUID |
| @@ -6,6 +6,7 @@ org.valiktor.constraints.NotEquals.message=Darf nicht gleich {value} sein | |||
| org.valiktor.constraints.In.message=Muss in {values} sein | |||
| org.valiktor.constraints.NotIn.message=Darf nicht in {values} sein | |||
| org.valiktor.constraints.Valid.message=Muss g\u00FCltig sein | |||
| org.valiktor.constraints.IsUUID.message=Kein g\u00FCltiger Bezeichner (uuid) | |||
There was a problem hiding this comment.
Suggested change
| org.valiktor.constraints.IsUUID.message=Kein g\u00FCltiger Bezeichner (uuid) | |
| org.valiktor.constraints.UUID.message=Muss eine gültige UUID sein |
| @@ -6,6 +6,7 @@ org.valiktor.constraints.NotEquals.message=No puede ser igual a {value} | |||
| org.valiktor.constraints.In.message=Tiene que ser uno de eses: {values} | |||
| org.valiktor.constraints.NotIn.message=No puede ser uno de eses: {values} | |||
| org.valiktor.constraints.Valid.message=Tiene que ser v\u00E1lido | |||
| org.valiktor.constraints.IsUUID.message=No es un identificador v\u00E1lido (uuid) | |||
There was a problem hiding this comment.
Suggested change
| org.valiktor.constraints.IsUUID.message=No es un identificador v\u00E1lido (uuid) | |
| org.valiktor.constraints.UUID.message=Tiene que ser uno UUID válido |
| @@ -6,6 +6,7 @@ org.valiktor.constraints.NotEquals.message=N\u00E3o deve ser igual a {value} | |||
| org.valiktor.constraints.In.message=Deve ser um desses: {values} | |||
| org.valiktor.constraints.NotIn.message=N\u00E3o deve ser um desses: {values} | |||
| org.valiktor.constraints.Valid.message=Deve ser v\u00E1lido | |||
| org.valiktor.constraints.IsUUID.message=N\u00E3o \u00E9 um identificador \u0028uuid\u0029 v\u00E1lido | |||
There was a problem hiding this comment.
Suggested change
| org.valiktor.constraints.IsUUID.message=N\u00E3o \u00E9 um identificador \u0028uuid\u0029 v\u00E1lido | |
| org.valiktor.constraints.UUID.message=Deve ser um UUID válido |
| @@ -119,3 +119,17 @@ class ValidTest { | |||
| entry(SupportedLocales.PT_BR, "Deve ser válido")) | |||
| } | |||
| } | |||
|
|
|||
| class IsUUIDTest { | |||
There was a problem hiding this comment.
It must be moved to TextConstraintsTest.kt
| property = "id", | ||
| value = "a3551f72", | ||
| constraint = IsUUID)) | ||
| } |
There was a problem hiding this comment.
It should be moved to StringFunctionsTest.kt
|
@rodolphocouto can we close this? It has been stale for more than a year and we have a new proposed solution on #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes