Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): add types file #2398

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(types): add types file #2398

wants to merge 2 commits into from

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented May 9, 2024

This PR adds types file within the repo itself .
The types file is derived from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator
with some modifications

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin
Copy link
Member Author

rubiin commented May 9, 2024

Having types file here will make sure the types and codebase are in sync.

@rubiin rubiin mentioned this pull request May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa Awaiting requested review from profnandaa

@WikiRik WikiRik Awaiting requested review from WikiRik

@ezkemboi ezkemboi Awaiting requested review from ezkemboi

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
🕑 to-be-reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rubiin @profnandaa