Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warns on some files on test/gurka #4702

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Remove warns on some files on test/gurka #4702

wants to merge 18 commits into from

Conversation

cvvergara
Copy link
Contributor

Issue

What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.

Tasklist

  • remove warnings from some tests
  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

nilsnolde
nilsnolde reviewed Apr 23, 2024
View reviewed changes
test/gurka/test_gtfs.cc Outdated Show resolved Hide resolved
@nilsnolde
Copy link
Member

nilsnolde commented Apr 23, 2024 •
edited

seems there's more warnings-as-errors with the compiler this job uses in Debug mode: https://app.circleci.com/pipelines/github/valhalla/valhalla/12845/workflows/798c750a-1c09-4c59-a160-3cc2c5dfdf17/jobs/64916

@nilsnolde nilsnolde mentioned this pull request Apr 23, 2024
Merged
cvvergara
cvvergara commented Apr 23, 2024
View reviewed changes
valhalla/baldr/time_info.h Outdated Show resolved Hide resolved
@cvvergara cvvergara marked this pull request as draft April 23, 2024 15:38
@cvvergara cvvergara marked this pull request as ready for review April 28, 2024 06:06
nilsnolde
nilsnolde requested changes Apr 29, 2024
View reviewed changes
test/gurka/test_phonemes.cc Show resolved Hide resolved
test/gurka/test_phonemes.cc Show resolved Hide resolved
valhalla/baldr/time_info.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsnolde nilsnolde nilsnolde requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cvvergara @nilsnolde