Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear state after time domain push #4620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

molind
Copy link
Contributor

@molind molind commented Mar 5, 2024

Issue

For string with two or more time intervals e.g. Mo-Sa 09:00-21:00; Su 10:00-20:00 current version returns second interval for all days of week.

After push we need to reset timedomain.

What do you think?

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@kevinkreiser
Copy link
Member

@gknisely this should be testable with some gurka right?

@molind
Copy link
Contributor Author

molind commented Mar 5, 2024

Also, I've noticed that 24/7 isn't parsed at all. Maybe that makes sense, because in Valhalla, this function is used to parse data when the road is closed.

@molind
Copy link
Contributor Author

molind commented Mar 5, 2024

DOW for 09:00-21:00 is empty. Is that expected behaviour?

@gknisely
Copy link
Member

gknisely commented Mar 6, 2024

DOW for 09:00-21:00 is empty. Is that expected behaviour?

Yes. Means the restriction is in place everyday for the time noted above

@gknisely
Copy link
Member

gknisely commented Mar 6, 2024

Also, I've noticed that 24/7 isn't parsed at all. Maybe that makes sense, because in Valhalla, this function is used to parse data when the road is closed.

Yes. People usually just add access=no

@gknisely
Copy link
Member

gknisely commented Mar 6, 2024

The old tests are here https://github.com/valhalla/valhalla/blob/master/test/timeparsing.cc but should be able to add a gurka test too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants