Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

almost have mn working #4712

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

almost have mn working #4712

wants to merge 8 commits into from

Conversation

kevinkreiser
Copy link
Member

hoping that after some changes this fixes #4688

@kevinkreiser
Copy link
Member Author

the main issue at present is:

[ RUN      ] UtilOdin.test_supported_locales
/home/kkreiser/sandbox/valhalla/test/util_odin.cc:195: Failure
Expected: (other_phrase.find(tag.str())) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Couldn't find <ROUNDABOUT_EXIT_STREET_NAMES> in mn-MN::enter_roundabout.phrases.5
/home/kkreiser/sandbox/valhalla/test/util_odin.cc:195: Failure
Expected: (other_phrase.find(tag.str())) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Couldn't find <ROUNDABOUT_EXIT_STREET_NAMES> in mn-MN::enter_roundabout.phrases.5
/home/kkreiser/sandbox/valhalla/test/util_odin.cc:195: Failure
Expected: (other_phrase.find(tag.str())) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Couldn't find <STREET_NAMES> in mn-MN::enter_roundabout.phrases.10
/home/kkreiser/sandbox/valhalla/test/util_odin.cc:195: Failure
Expected: (other_phrase.find(tag.str())) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Couldn't find <STREET_NAMES> in mn-MN::enter_roundabout.phrases.10
/home/kkreiser/sandbox/valhalla/test/util_odin.cc:195: Failure
Expected: (other_phrase.find(tag.str())) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Couldn't find <ROUNDABOUT_EXIT_STREET_NAMES> in mn-MN::enter_roundabout_verbal.phrases.5
/home/kkreiser/sandbox/valhalla/test/util_odin.cc:195: Failure
Expected: (other_phrase.find(tag.str())) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Couldn't find <ROUNDABOUT_EXIT_STREET_NAMES> in mn-MN::enter_roundabout_verbal.phrases.5
/home/kkreiser/sandbox/valhalla/test/util_odin.cc:195: Failure
Expected: (other_phrase.find(tag.str())) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Couldn't find <STREET_NAMES> in mn-MN::enter_roundabout_verbal.phrases.10
/home/kkreiser/sandbox/valhalla/test/util_odin.cc:195: Failure
Expected: (other_phrase.find(tag.str())) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Couldn't find <STREET_NAMES> in mn-MN::enter_roundabout_verbal.phrases.10
[  FAILED  ] UtilOdin.test_supported_locales (845 ms)

@kevinkreiser kevinkreiser mentioned this pull request Apr 27, 2024
Open
@kevinkreiser kevinkreiser marked this pull request as ready for review April 27, 2024 02:22
kevinkreiser
kevinkreiser commented Apr 27, 2024
View reviewed changes
CHANGELOG.md
@@ -21,7 +21,7 @@
* FIXED: motorcar:conditional should not apply to motorcycle and moped [#4359](https://github.com/valhalla/valhalla/pull/4359)
* FIXED: break shortcuts when there are different restrictions on base edges [#4326](https://github.com/valhalla/valhalla/pull/4326)
* FIXED: Incorrect `edge_index` assignment in `thor_worker_t::build_trace` [#4413](https://github.com/valhalla/valhalla/pull/4413)
* FIXED: lots of issues with CostMatrix (primarily deadend logic) with a complete refactor modeling things very close to bidir A*, also to prepare for a unification of the two [#4372](https://github.com/valhalla/valhalla/pull/4372)
* FIXED: lots of issues with CostMatrix (primarily deadend logic) with a complete refactor modeling things very close to bidir A\*, also to prepare for a unification of the two [#4372](https://github.com/valhalla/valhalla/pull/4372)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one must escape asterisk in markdown

@kevinkreiser
Copy link
Member Author

kevinkreiser commented Apr 27, 2024 •
edited

i guess im cursed! seems somehow the macos build has std::string support disabled for rapidjson somehow..

@nilsnolde
Copy link
Member

I can give it a shot on the M1 I got here

@nilsnolde
Copy link
Member

surprise, osx is giving me a hard time.. sqlite is fussing around, couldnt get a build yet and little nerves right now to deal with brew stuff;)

@kevinkreiser
Copy link
Member Author

kevinkreiser commented Apr 29, 2024 •
edited

i was able to ssh into the mac machine in CI to troubleshoot so no worries there but i just didnt have a ton of time to sink into it yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MN Translation
2 participants
@kevinkreiser @nilsnolde