Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MN Translation #4688

Open
Uranbold opened this issue Apr 15, 2024 · 9 comments · May be fixed by #4712
Open

MN Translation #4688

Uranbold opened this issue Apr 15, 2024 · 9 comments · May be fixed by #4712
Labels

Comments

@Uranbold
Copy link

Hello,

I've translated the Mongolian Language on Transifex. So how can I Include the translation into the Main Valhalla? I saw the Documentation and it's gonna included in the next version. So how long does it take?

@nilsnolde
Copy link
Member

Actually we just need to raise a PR with the transifex files. We typically do that before releases, but can be done anytime. It’ll likely need an admin to do that, not sure how well we’re currently synchronized.

@kevinkreiser
Copy link
Member

i can give this a try

@kevinkreiser
Copy link
Member

looks like theres a problem with the tooling. corrently no updates are pulled and it seems to be because transifex started not liking our use of - between the locale parts. if you force pull with an _ instead it pulls the file.. i'll play around some more with it this evening

@kevinkreiser
Copy link
Member

ok i figured it out, is a bit cumbersome. will pr later on

@Uranbold
Copy link
Author

Thank you. @kevinkreiser i'm newbie here and trying to improve it.

@kevinkreiser
Copy link
Member

still working on this. i was able to pull the mn one but there are more id like to pull. ive also got to update the template on transifex due to the blind mode updates

@kevinkreiser
Copy link
Member

well this is almost working but your translation is missing some things. one i could fix easily, you didnt set the posix locale nor the alias that was easily fixed, the other one is your roundabout phrases are missing some tags. you'll need to add those in the right places for us to be able to accept your translation.

@kevinkreiser kevinkreiser linked a pull request Apr 27, 2024 that will close this issue
@kevinkreiser
Copy link
Member

@Uranbold here you can see the exact phrases that have missing tags: #4712 (comment)

@kevinkreiser
Copy link
Member

oh hahahahah its just a typo.. missing underscores hahahahah 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants