Add deactivate function to clean up languageClient #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain what problem you are trying to fix, and what your changes do in order to fix it.
Link related issues or pull requests.
A
deactivatefunction should be defined for the extension, see here. This PR moves the api object to the module level and then defines adeactivatefunction to call thelanguageClient.stopwhich is similar to the example lsp-server.I tried to see if this would solve #497 but running with debug in VSCode seems to remove the stray java process so couldn't confirm this change fixes it.
Checklist