Add new introspectable Vlint library #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new library is introspectable, so it produce GIR/TYPELIB files to be used by JavaScript, Python and any other library introspectable depending on it. These changes also fix memory leaks because when running checks for files it never removes created Vala.Context using pop() method.
kgrubb
approved these changes
Feb 16, 2022
|
@esodan aside from the build file conflict, this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new library is introspectable, so
it produce GIR/TYPELIB files to be used
by JavaScript, Python and any other library
introspectable depending on it.
These changes also fix memory leaks because
when running checks for files it never
removes created Vala.Context using pop()
method.