meson: support settings overrides from editor #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces settings overrides (`EditorOptions`) passed from the editor to the server in the initialize() call. These overrides are just currently for the Meson backend. The intent is to have the vala-vscode extension send these options from the Meson VSCode extension to VLS. Closes #304 and #305.
|
@PterX try out this branch along with the experimental version of Vala-VSCode I attached (unzip first, then install the |
|
@PterX ping for testing |
lw64
reviewed
Apr 22, 2024
| try { | ||
| meson_build_dir.make_directory_with_parents (cancellable); | ||
| this.build_dir = editor_options.mesonBuildDir; | ||
| } catch (IOError.EXISTS e) { |
There was a problem hiding this comment.
the cancellable error isnt handled here I think
| */ | ||
| class EditorOptions : Object { | ||
| public EditorType editorType { get; set; } | ||
| public string[] mesonConfigureOptions { get; set; } |
There was a problem hiding this comment.
I believe arrays arent "native" gobject properties, so they probably cannot be serialized automatically. I guess you need to implement the Json.Serializable interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces settings overrides (
EditorOptions) passed from the editor to the server in the initialize() call. These overrides are just currently for the Meson backend. The intent is to have the Vala VSCode extension send these options from the Meson VSCode extension to VLS.Closes #304
Closes #305
Requires vala-lang/vala-vscode#31 to be merged.