Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore networks that disappear during discovery #1815

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamie01
Copy link
Contributor

@jamie01 jamie01 commented Apr 5, 2024

On systems where we have multiple concurrent deployments and teardowns of virtual machines that overlap, there are occasions where setup can fail if teardown of another vagrant deployment is happening in parallel. Generally this is handled well, but the most common place of failure was in the network enumeration where details of all existing networks are collected prior to creating new ones.

Since a number of operations are done after driver.list_all_networks and in cases where the number of networks is relatively large, it was common for a network to be destroyed during the iterations of that loop and thus the XML lookup or queries for bridge_name etc would fail.

My change here is just to rescue any errors that occur in this loop and continue on. I understand this is a bit of a niche issue for us in the way vagrant-libvirt is used at scale, and this might mask other problems besides networks being cleaned up, but opening this PR anyway for thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant