Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with webkit < 2.9.2 #345

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Fix building with webkit < 2.9.2 #345

wants to merge 4 commits into from

Conversation

ramok
Copy link

@ramok ramok commented Feb 5, 2017

No description provided.

@keis
Copy link
Member

keis commented Feb 6, 2017

it was added it 2.10 so it shouldn't be added for 2.9 see https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebsiteDataManager.html#WebKitWebsiteDataManager--disk-cache-directory

we need to do another #if check before adding it to the variables table

@mathstuf
Copy link
Member

mathstuf commented Feb 7, 2017

Upstream never says that symbols are new in x.<odd> releases since they are development versions. You need to look at the actual tarballs to see what releases have which symbols. I'll double check this (I have a git repo with a commit per-release of webkitgtk).

@mathstuf mathstuf self-assigned this Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants