-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Default parsing event command #252
base: master
Are you sure you want to change the base?
Conversation
@@ -498,6 +498,8 @@ split_quoted (const gchar *src, const gboolean unquote) | |||
} else if (isspace (*p) && !ctx_double_quote && !ctx_single_quote) { | |||
/* Argument separator. */ | |||
/* FIXME: Is "a b" three arguments? */ | |||
for (; isspace(*(p + 1)); ++p); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, a while
loop would look better, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's going to look a bit derpy anyway because I need it to stop AT the last space and not one past it.
It might be worthwhile to have something like |
yeah. I think it's unavoidable that is going to break stuff. Could be worth changing some other commands at the same time (like set) while at it. |
23adbb9
to
1b81618
Compare
Trying this out a bit and my gut feeling is that it will be hard to do without changing every command at once. I'll try to split some small changes out of this that can be merged without breaking stuff. |
1b81618
to
8a9068f
Compare
This allows us to send the data as quoted strings rather than pass them through raw which has the side effect of dropping a level of escapes due to the earlier pass done in uzbl-core. Update bind and on_event plugins to use already quoted arguments. Ref uzbl#251
8a9068f
to
07ec48c
Compare
Sadly breaking small things all over the place. But imo we should eventually push everything into using the default split logic of core and em respectively.