Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increased key hint size and added borders #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

GSI
Copy link
Contributor

@GSI GSI commented Jan 29, 2016

IMHO, a link hint size of 9px is eye-strain tiny.

This commit contains some suggested improvements.

@mathstuf
Copy link
Member

Not against it, but I'll have to see the change. They were small before so they didn't hide what you were following (a pet peeve of many other implementations of the feature in other browsers). But I can fix my config too :) .

@GSI
Copy link
Contributor Author

GSI commented Jan 29, 2016

Personally, I realized that I am first looking at which link I want to visit, then I bring up the hints.

Thus, whatever is blocking my view to the original link at that moment is what I want to enter at that point :)

@keis
Copy link
Member

keis commented Jan 29, 2016

Depending on line height used on the page this can cause issues. Or rather cause issues more often simply because more pages will use a font-size smaller than what we use for the hints.

selection_001

@keis
Copy link
Member

keis commented Feb 9, 2016

A more modest increase to 12x and 1px border should still work pretty well in most cases. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants