Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Enable Remote Configuration' nor 'Enable Remote Commands' from bootstrap scrip #8709

Merged
merged 2 commits into from May 22, 2024

Conversation

admd
Copy link
Contributor

@admd admd commented May 10, 2024

What does this PR change?

After traditional stack removal, 'Enable Remote Configuration' nor 'Enable Remote Commands' in bootstrap script doesn't make sense and this PR removes them.

GUI diff

No difference.

Before:

After:

  • DONE

Documentation

  • No documentation needed: These options were only meaningful in traditional stack context.

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@admd admd requested review from a team as code owners May 10, 2024 13:29
@admd admd requested review from rjmateus and m-czernek and removed request for a team May 10, 2024 13:29
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8709/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8709/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

Suggested tests to cover this Pull Request

@admd admd force-pushed the remove-tradtional-stack-related-options branch 2 times, most recently from c32ff53 to 183942c Compare May 10, 2024 14:42
@admd admd requested a review from rjmateus May 13, 2024 09:35
Copy link
Member

@rjmateus rjmateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@admd admd force-pushed the remove-tradtional-stack-related-options branch from 183942c to ace9795 Compare May 20, 2024 07:58
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test failing

@admd admd force-pushed the remove-tradtional-stack-related-options branch from ace9795 to 7bb23b4 Compare May 20, 2024 16:16
@admd admd force-pushed the remove-tradtional-stack-related-options branch from 7bb23b4 to 36a8add Compare May 20, 2024 17:06
@admd
Copy link
Contributor Author

admd commented May 20, 2024

ah indeed, It should be fine now. Thank you @mcalmer

@admd admd merged commit 3f0fb51 into master May 22, 2024
23 checks passed
@admd admd deleted the remove-tradtional-stack-related-options branch May 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants