Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE: Review migration features #8708

Merged

Conversation

NamelessOne91
Copy link
Contributor

@NamelessOne91 NamelessOne91 commented May 9, 2024

What does this PR change?

Related to https://github.com/SUSE/spacewalk/issues/24233

Removes unused and not up to date OS salt packages from minions which are going to attempt a Product migration.

Not sure if this is a bug, but having those packages on the minion will otherwise stop product migrations as long as they are not updated to the last version (even if the system is using venv-salt or is managed via SSH).

I've also noticed a place in which we use -n with transactional update but I think we meant to use -y to skip the prompt for confirming packages installation.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Cucumber test features and step definitions were modified

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24233
Port(s): SUMA 4.3 https://github.com/SUSE/spacewalk/pull/24304

  • DONE

Changelogs

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@NamelessOne91 NamelessOne91 requested a review from a team as a code owner May 9, 2024 16:29
Copy link
Contributor

github-actions bot commented May 9, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8708/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8708/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@NamelessOne91 NamelessOne91 changed the title Review migration features QE: Review migration features May 9, 2024
@NamelessOne91 NamelessOne91 self-assigned this May 9, 2024
@NamelessOne91
Copy link
Contributor Author

Added a small change to the directory check done in the salt migration feature file.

It seems that switching from OS Salt to venv-salt is moving files from /etc/salt to /etc/venv-salt-minion but not deleting the root directory itself.

@deneb-alpha deneb-alpha merged commit a30a00c into uyuni-project:master May 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants