-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print detailed error messages on AppStreams action failure #8703
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
d422869
to
c2738ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
// Filter out the subsequent errors to find the root cause | ||
var originalErrorMsg = jsonEventToStateApplyResults(jsonResult) | ||
.map(SaltUtils::getOriginalStateApplyError) | ||
.orElseThrow(() -> new RuntimeException("Failed to parse the state.apply error result")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can avoid throwing this exception here. If the message comes in some kind of strange format, not containing the expected comment pattern, we can simply not fill in the result message field. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is actually impossible to reach in normal circumstances, as long as the result belongs to a state.apply
call, which always is in our case, but findFirst
in the stream API returns an Optional. I added the RuntimeException
here because if it happens something is weird and we should look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I'm aware that it seems to be unreachable, so it is just nitpick from my side. Although I still think that not having the exception here would be better. Feel free to keep it as is 👍 .
Parse the failed
state.apply
result and print its comment in the failed action details.GUI diff
Before:
After:
Documentation
Test coverage
Links
Fixes https://github.com/SUSE/spacewalk/issues/24197
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!