Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dev containers for testing e2e tests and building java code #8701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srbarrios
Copy link
Member

@srbarrios srbarrios commented May 7, 2024

What does this PR change?

This PR aims to provide two different devcontainers.
One for testing purposes, acting as a controller vm.
The other for building java code.

Notice that for .devcontainer/test/id_rsa_test_env we already have a similar commit here testsuite/features/upload_files/ssh_keypair, so it should be fine.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • No tests

  • DONE

Links

Ports:

  • Manager-4.3

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@srbarrios srbarrios force-pushed the dev-containers branch 3 times, most recently from 2429744 to 85bae40 Compare May 8, 2024 14:15
@srbarrios srbarrios self-assigned this May 8, 2024
@srbarrios srbarrios marked this pull request as ready for review May 8, 2024 14:24
@srbarrios srbarrios requested review from renner, mbussolotto and a team May 8, 2024 14:26
@srbarrios
Copy link
Member Author

srbarrios commented May 15, 2024

@renner @mbussolotto @uyuni-project/qe
This works, and this is completely isolated from any other code in the repository, so let me know you if you agree on merging this please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant