Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore ONTIMEOUT pxe in cobbler case #8690

Merged
merged 1 commit into from May 15, 2024

Conversation

aaannz
Copy link
Contributor

@aaannz aaannz commented May 3, 2024

What does this PR change?

Recent addition of cobbler translations also made cobbler to ignore ONTIMEOUT syslinux entries, like saltboot does because it generates new one. This is not correct in cobbler scenario.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: covered by integration/acceptance tests

  • DONE

Links

Issue(s): # https://github.com/SUSE/spacewalk/issues/24249
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@aaannz aaannz requested a review from a team as a code owner May 3, 2024 12:00
@aaannz aaannz requested review from agraul and removed request for a team May 3, 2024 12:00
@avshiliaev
Copy link
Contributor

Copy link
Member

@agraul agraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you that the semantics are right 😃, LGTM 🚀

@aaannz aaannz merged commit 57b0a35 into uyuni-project:master May 15, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants