Fix query params inclusion in Query::toAST #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods<Type> -> parse, and pull out query params if opt.query is supplied, and add a test for it.
…(func) -> map(dummyVar => func(dummyVar, opt)) refactors)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please excuse the PR re-lodge)
As far as I can tell, the Options type is incapable of using params, so I've elected not to pass opt to astOptions (or astTableRef for that matter)
At the moment, getParams is exclusive - so you either get table.params, OR {...t1.params, t2.params} OR query.params. Merging a table or constituent tables' params with those embedded in a query makes sense, though it's uncertain which should have higher precedence - I'm open to implementing this (it's a tiny change anyway), let me know which order you'd prefer.
Closes #222