Correctly render void elements #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A [void element] is an HTML element that **cannot** have any children. In XML you'd use such an element like `<br />`. HTML5 is very lenient, in that you don't have to write the trailing slash. A correctly implemented HTML parser *knows* which elements are void elements, and it closes the element automagically for you. The parser even "corrects" an input like `a<br></br>b` to `a<br /><br />b` for you, which might not desirable. If you want to render SVG, XHTML, or other more strict XML applications, you have to close void elements correctly: `<br />`, NOT `<br>` or `<br></br>`. This PR adds the missing slash to generated void elements, so `markup` can be used to render e.g. SVG files. [void element]: https://developer.mozilla.org/en-US/docs/Glossary/Void_element
This comment was marked as resolved.
This comment was marked as resolved.
|
So, 3 out of 4 commits are now unrelated to the title of the PR. Should I move them into a new PR, or do you not mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A void element is an HTML element that cannot have any children. In XML you'd use such an element like
<br />.HTML5 is very lenient, in that you don't have to write the trailing slash. A correctly implemented HTML parser knows which elements are void elements, and it closes the element automagically for you. The parser even "corrects" an input like
a<br></br>btoa<br /><br />bfor you, which might not be desirable.If you want to render SVG, XHTML, or other more strict XML applications, you have to close void elements correctly:
<br />, NOT<br>or<br></br>.This PR adds the missing slash to generated void elements, so
markupcan be used to render e.g. SVG files.