Use CMake 3.18's built-in CMAKE_CUDA_ARCHITECTURES support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows altis to build with Cuda 10.1's nvcc
|
The default cmake on Ubuntu 20.04 is 3.16, so this is probably not good to merge now. There might be another workaround. |
|
Or if we want to use the latest and greatest cmake, just include some instructions with the setup script on how to get it. |
BDHU
reviewed
Jun 12, 2021
There was a problem hiding this comment.
I will probably take a look into this. It will be optimal if the user doesn't have to manually upgrade the distro's cmake to accommodate the need to generate correct gencode flags. Since not all distros use apt as their package manager it might be hard to cover all use cases on Linux correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows Altis to build with Cuda 10.1's nvcc