now osm displays with google, but not the other way #1389
Conversation
|
We should always allow OSM but we don't necessarily need to do it the other way around. If that's the case, then we're always including libraries for baselayers that are more than likely never going to be toggled. Alternatively, we could load those libraries on demand but that's a much larger issue. I haven't had a chance to review this yet but I will. |
|
Ok, I will look into adding osm always next. Please test what I did and let On Wed, Jul 2, 2014 at 2:03 PM, Brian Herbert notifications@github.com
James Michael DuPont |
|
First off, apologies it took a while to get back. I was away for the 4th. On a default install of Ushahidi, where the default map is OSM (osm_mapnik), the map doesn't load since the google library isn't being included in the header. Since we only want to show OSM as an additional provider when the site is set to a separate provider (Google, Bing, etc), we shouldn't include Google when OSM is set.
|
|
Hope you had a great independance day. On Mon, Jul 7, 2014 at 8:31 AM, Brian Herbert notifications@github.com
yes, I understand. I will turn it on for the other providers. James Michael DuPont |
The showing of osm with google works, but showing of google with osm still needs an include. that needs to be figured out, I am thinking about making an a list of src url that will be included and not just one. But for now this should solve your issue #1378 @brianherbert