refactor secdist: get rid of DefaultSecdistProvider component #573
+277
−340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'default-secdist-provider'
mnink275
changed the title
mnink275
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue #547
The main changes are made in the directory:
core/{include/userver,src}/storages/secdist/components::DefaultSecdistProvidercomponent has been removed.components::SecdistComponentBase- base component for all secret distributors. The default implementation of this class iscomponents::Secdist- ready-to-use component.storages::secdist::SecdistProviderclass is now used to store the secdist configuration.Thus it is still possible to implement your own secret distributor by implementing the base classes
components::SecdistComponentBaseandstorages::secdist::SecdistProvider.