Set balance below existential #1983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faculerena
requested review from
cmichi,
ascjones and
SkymanOne
as code owners
faculerena
force-pushed
the
set-balance-below-existential
branch
2 times, most recently
from
0e4f785
to
81a9ae9
Compare
|
Please merge master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cargo-contractorpallet-contracts?Added a check for setting the balance in tests below the existential minimum
Description
Given that accounts with a balance below the existential minimum get reaped, adding a check to prohibit setting balance below seems logical. If this should not be like this, feel free to correct us.
Checklist before requesting a review
CHANGELOG.md