Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance integration fix #1982

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Balance integration fix #1982

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
757c15a
Fixed balance default value in the integration tests
faculerena Nov 8, 2023
2a16554
Restored import formatting
faculerena Nov 9, 2023
8ec3b37
Changed the default account balance to the testnet genesis default
faculerena Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/env/src/engine/off_chain/test_api.rs
View file
Open in desktop
Expand Up @@ -306,7 +306,8 @@ where
instance.engine.set_callee(encoded_alice.clone());

// set up the funds for the default accounts
let substantial = 1_000_000;
// the 1_000_000_000 is the same value as in the e2e tests
let substantial = 1_000_000_000;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original 1_000_000 value was somewhat arbitrary anyway, so makes sense to change it to be the same as the substrate-contracts-node used for testsin.

Is it only the Alice account that is endowed with this amount? I see bob and charlie are still set to 1_000 below - does that match up with the endowed amounts for the e2e tests too? Seems kind of low.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, i will check the behaviour and make it equal for all name accounts (at least). The accounts created with ::From([1;32]) should have a balance of 0 or the existential minimum?

let some = 1_000;
instance.engine.set_balance(encoded_alice, substantial);
instance
Expand Down