Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring democracy #1888

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bring democracy #1888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df97160
Update CONTRIBUTING.md
SkymanOne Aug 24, 2023
3306296
Update CONTRIBUTING.md
SkymanOne Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -141,15 +141,15 @@ For a nice list of hints visit this [link][GitHub Perfect Pull Reqest].

### Reviews

We have GitHub set up in a way that core developers will automatically
be assigned to review your pull request. If you feel there is somebody
missing you're always free to add more people for a review.
As we grow, we gradually allow the most active contributors to review and approve pull requests.

For small changes one approval is typically enough to merge code, for
significant or critical changes there should be at least two ✅.
Therefore, for the pull request to get merged at least 2 approvals from 2 different parties, including
1 approval from a [CODEOWNER](/CODEOWNERS), must be granted.

This policy may be subject to change depending on the circumstances.

If you made major changes to your pull request since the last approval,
ping them for another approval please.
ping reviewers for another approval, please.

## I don't want to contribute, I just have some questions

Expand Down