This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Add support for animated tilesets (tmx files) #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently it causes crashes in two samples. |
|
I believe I got the problem solved. Waiting for the tests to complete. |
|
Although I have not tested it, I believe it is merge-ready. I would have merge it if the script API binding is also provided. |
|
The bindings for TmxFile2D were incomplete, both in LUA and AS. I added bindings for some methods, but the ones still remaining left me uncertain of how to do it. |
|
Marking this stale since there has been no activity for 30 days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the use of animated tiles in tmx maps.
I tested it by updating the map of sample 36 to contain some animated tiles.
I don't know if the way I choose to implement this fits with the codebase (I tried to). If it does, I'll check AS and LUA bindings. I'm dabbling with those bindings, so I'll only commit to that code if this one is ok.