Support Urho3D version like SDL #2525
Conversation
|
While this is neat. I don't see people dealing with backwards compatibility. Or the engine itself. The way I see it is you pick a version and stick with it. Or maybe upgrade in the future. But not really go back. Going back is like asking to bring back fixed issues. SDL needs this because there are wrappers and other such things that need to deal with compatibility across multiple versions of the library. I could be wrong. So feel free to ignore my thoughts. |
|
Although I like the idea, there are a number of issues in the implementation as apparently the change has broken the CI build test. For one, as you may have already known, the "minor" part is now not necessarily a number anymore (consider 1.8-ALPHA for example). You have commented out a logic to prevent the generated header from changing its timestamp and therefore the new change might trigger a rebuild unnecessarily (if the content is stale then user can easily do a "make clean" to mitigate rather than removing this logic). I don't think I will merge this PR as it is but because of it at least it pointed out we have a bug in version parsing to cater for -ALPHA/BETA/RC. So thanks for that. |
|
@weitjong Thanks for your reply.
I'm not sure what you mean. and I didn`t change the version parsing. |
|
I can see what you tried to do and understand your intend, moving the existing code up before the if() branch. However, what I wanted to say is, that existing code was actually out-dated. My last commits bring the parsing logic up to speed now. But I see the latest commit in your PR just nullifying my work. |
|
@weitjong Oh, sorry. I see. |
Port Light2D from AtomicGameEngine
current HEAD -> 1.8-ALPHA.11 tag 1.8-ALPHA -> 1.8-ALPHA.0 one commit before 1.8-ALPHA -> 1.7.759 tag 1.7 -> 1.7.0 one commit before 1.7 -> 1.6.1152
This reverts commit c7edfdd.
|
Stale pull request message |
weitjong
added
backlog
улучшение
No description provided.