Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Drag components in editor #2192

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Drag components in editor #2192

wants to merge 31 commits into from

Conversation

orefkov
Copy link
Contributor

@orefkov orefkov commented Nov 27, 2017

This changes in editor allow drag components from hierarchy window to inspector's attributes editor.
It allow set ScriptInstance's attributes to component ID, for reference to component.
Early it worked only with nodes.

Fixed problem with calling function expecting @&in where the argument was itself a & argument.
https://www.gamedev.net/topic/686912-array-with-objects-handles/
…t(const String&) and allow searching by implemented interfaces.
…t(const String&) and allow searching by implemented interfaces.

Fix tabs and CString
Conflicts:
	Source/Urho3D/AngelScript/ScriptInstance.cpp
…es in deserealization.

Add metod Swap in Array<T> script object for swap content of two arrays for avoid copy.
… ScriptInstance.

Add metod Swap in Array<T> script object for swap content of two arrays for avoid copy.
… Urho3D detect joystick only 1-2 times from 10-20 runs.

Now joysticks worked perfectly - in tests, I connected two joysticks at the same time - one through bluetooth, another through USB - both were visible in the game.
Conflicts:
	Source/Urho3D/AngelScript/Addons.cpp
	Source/Urho3D/AngelScript/ScriptInstance.cpp
…editors, for example to set references on components in ScriptInstance's attributes.
@Lumak
Copy link
Contributor

Lumak commented Dec 10, 2017

I think you've included some SDL changes by accident, and I'm still skeptical as to why the SDL_TICKS_PASSED() condition doesn't evaluate to true on init.

@orefkov
Copy link
Contributor Author

orefkov commented Dec 13, 2017

That bug already fixed in SDL - https://bugzilla.libsdl.org/show_bug.cgi?id=3935
In SDL_TICKS_PASSED used signed comparation, and after approx 24 days of uptime ticks in signed form become negative, and 0 always grater than negative value, and comparation is always false.
SDL_TICKS_PASSED must be used with previous saved ticks, not with 0.

@Lumak
Copy link
Contributor

Lumak commented Dec 13, 2017

My question is, how did you manage to set a condition to test this 24-days-of-uptime-ticks?

@github-actions
Copy link

Marking this stale since there has been no activity for 30 days.
It will be closed if there is no activity for another 15 days.

@github-actions github-actions bot added the stale label Mar 24, 2020
@weitjong weitjong added backlog and removed stale labels Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants