Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce a new BorderVisual to handle rendering the border and the background #16562

Merged
merged 31 commits into from May 16, 2024
Merged

feat: introduce a new BorderVisual to handle rendering the border and the background #16562

merged 31 commits into from May 16, 2024

Conversation

ramezgerges
Copy link
Contributor

@ramezgerges ramezgerges commented May 2, 2024 •
edited

This fixes a bunch of rendering problems in borders and simplifies the logic significantly.

GitHub Issue (If applicable): closes #16518, closes #16294

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels May 2, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@ramezgerges ramezgerges force-pushed the bordershapevisual branch 2 times, most recently from eeef4ba to 4215061 Compare May 4, 2024 15:37
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@ramezgerges ramezgerges force-pushed the bordershapevisual branch 2 times, most recently from 8e9e1ce to 5883c25 Compare May 4, 2024 19:35
@ramezgerges ramezgerges marked this pull request as draft May 4, 2024 19:44
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

@ramezgerges
Copy link
Contributor Author

Before:
image
After (uno left, winui right):
image

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@ramezgerges ramezgerges marked this pull request as ready for review May 9, 2024 08:39
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@ramezgerges ramezgerges mentioned this pull request May 13, 2024
Closed
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

@dr1rrb dr1rrb mentioned this pull request May 15, 2024
Open
6 tasks
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

@ramezgerges ramezgerges merged commit 724f51a into unoplatform:master May 16, 2024
103 checks passed
@ramezgerges ramezgerges deleted the bordershapevisual branch May 16, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@dr1rrb dr1rrb dr1rrb approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WPF Desktop] Blank app TextBox context menu is not fluent Remove BorderLayerRenderer on skia
4 participants
@ramezgerges @unodevops @dr1rrb @Youssef1313