fix(wpf): Fix IsLeftButtonPressed status on WPF platform #16517
Conversation
github-actions
bot
added
the
area/skia ✏️
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16517/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16517/index.html |
| @@ -111,7 +111,9 @@ public void ReleasePointerCapture() | |||
| => _hostControl.ReleaseMouseCapture(); | |||
|
|
|||
| #region Native events | |||
| private void HostOnMouseEvent(InputEventArgs args, TypedEventHandler<object, PointerEventArgs>? @event, [CallerArgumentExpression(nameof(@event))] string eventName = "") | |||
|
|
|||
There was a problem hiding this comment.
@jeromelaban, @dr1rrb should we add more tests related to these changes?
There was a problem hiding this comment.
A manual test would be useful, if we don't have any.
There was a problem hiding this comment.
@jeromelaban Any update here? Or what should I do? Thank you.
There was a problem hiding this comment.
@lindexi yes, in general, if testing is difficult because if requires integration with the outer platform, we add a "manual test" page which explains what to do, and what the outcome is. Something like this:
There was a problem hiding this comment.
@jeromelaban Thank you. I've attempted to add a test file, but I'm unsure if I've done it correctly. If I have, how should I write the code for the test file to make the test engineers happier? Would it suffice to just output the parameters to the console?
There was a problem hiding this comment.
Thanks @lindexi, yes, this is the right way to do it. You can add a listview or a textbox that will concatenate the events so that QA can validate that the events are raised properly.
There was a problem hiding this comment.
@jeromelaban Thank you very much.
There was a problem hiding this comment.
@jeromelaban I updated my test files. Could you review my code? Thank you.
Head branch was pushed to by a user without write access
github-actions
bot
added
the
area/automation
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16517/index.html |
lindexi
force-pushed
the
t/lindexi/WpfCorePointerInputSource
branch
from
63212b3
to
4591023
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16517/index.html |
agneszitte
requested review from
jeromelaban,
dr1rrb,
MartinZikmund,
Youssef1313 and
Xiaoy312
GitHub Issue (If applicable): #14393
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We can receive the pointer event with IsLeftButtonPressed is true when touch release.
What is the new behavior?
We can receive the pointer event with IsLeftButtonPressed is false when touch release.
See https://github.com/unoplatform/uno/pull/16378/files#r1575262313
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Cc @dr1rrb , and I will add more information about the barel button and the eraser status later.
Internal Issue (If applicable):