Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in unoconv, where the
--user-profile
flag is not respected and not passed tosoffice
. There seem to be two code paths which are responsible for launchingsoffice
, but only one of them respects--user-profile
.So, when we ran
unoconv --listener --port 3030 --user-profile=/tmp/unoconv-1
, before this pull request, the user profile was not set insoffice
(no-env:UserInstallation
):But now it is set properly: