Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user profile for listener #603

Closed
wants to merge 1 commit into from
Closed

Conversation

Acconut
Copy link

@Acconut Acconut commented Apr 19, 2023

This pull request fixes a bug in unoconv, where the --user-profile flag is not respected and not passed to soffice. There seem to be two code paths which are responsible for launching soffice, but only one of them respects --user-profile.

So, when we ran unoconv --listener --port 3030 --user-profile=/tmp/unoconv-1, before this pull request, the user profile was not set in soffice (no -env:UserInstallation):

$ ps -elf | grep soffice
[...] /lib/libreoffice/program/soffice.bin --headless [...] --accept=socket,host=127.0.0.1,port=3030,tcpNoDelay=1;urp;StarOffice.ComponentContext

But now it is set properly:

$ ps -elf | grep soffice
[..] /lib/libreoffice/program/soffice.bin --headless [..] --accept=socket,host=127.0.0.1,port=3030,tcpNoDelay=1;urp;StarOffice.ComponentContext -env:UserInstallation=file:///tmp/unoconv-1

@Acconut
Copy link
Author

Acconut commented Apr 19, 2023

A similar fix is also included in the (unmerged) PRs #519 and #558

@Acconut
Copy link
Author

Acconut commented Jul 6, 2023

Closing this because unoconv is superseeded by unoserver.

@Acconut Acconut closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant