feat(governance): add Base supports for cross-chain calls using Connext bridge #13679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien51
reviewed
Apr 26, 2024
| const daoChainId = 1 | ||
| const daoDomainId = allNetworks.networks[daoChainId].governanceBridge.domainId | ||
|
|
||
| // in seconds | ||
| const ONE_DAY = 24 * 3600 | ||
|
|
||
| // if any network is present this array, only these will be executed | ||
| const only = ['polygon', 'gnosis', 'bsc', 'arbitrum', 'optimism'] | ||
| const only = ['polygon', 'gnosis', 'bsc', 'arbitrum', 'optimism', 'base'] |
There was a problem hiding this comment.
We should mobve that config to the package network. Maybe a flag there?
There was a problem hiding this comment.
I dont think we gain much by automating it here. The script is just a parser to show command line, it does not actually execute anything
julien51
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds info about the governance contracts deployed on Base to perform cross governance tasks
Issues
Fixes #
Refs #13463
Checklist:
Release Note Draft Snippet