Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(governance): bridge UDT on ARB and OP chains #13521

Merged
merged 37 commits into from Apr 5, 2024
Merged

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Mar 26, 2024

Description

This adds a way to deploy a bridged token to Optimism chains, as well as a script to bridge some tokens.

  • deploy bridged erc20 on ARB
  • deploy bridged erc20 on OP
  • deploy bridged erc20 on Base
  • deploy bridged erc20 on Base Sepolia
  • test token bridge on ARB
  • test token bridge on OP
  • test token bridge on Base Sepolia
  • test token bridge on Base

Issues

Refs #11676

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@clemsos clemsos requested a review from julien51 March 26, 2024 12:03
@cla-bot cla-bot bot added the cla-signed label Mar 26, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing. This should go into governance folder. We should be able to solve the sdk ethers5 issue with yarn resolutions but I hadnt been able too so far ethereum-optimism/optimism#6295

const { ethers } = require('hardhat')
const optimism = require('@eth-optimism/sdk')

const L1_UDT_SEPOLIA = '0x0B26203E3DE7E680c9749CFa47b7ea37fEE7bd98'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it from the networks package please?

async function main({
l1TokenAddress = L1_UDT_SEPOLIA,
l2TokenAddress = L2_UDT_OP_SEPOLIA,
l1ChainId = 11155111, // Sepolia
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neworks package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. We dont have OP Sepolia in it. I was going to add Base Sepolia in networks package so maybe use that as default after

@clemsos clemsos changed the title feat(governance): OP bridged token for UDT feat(governance): bridge UDT on ARB and OP chains Mar 29, 2024
@clemsos clemsos marked this pull request as ready for review March 29, 2024 11:54
@clemsos
Copy link
Member Author

clemsos commented Mar 29, 2024

It happens that UDT was already bridged on Arbitrum... https://arbiscan.io/address/0xd5d3aA404D7562d09a848F96a8a8d5D65977bF90#readProxyContract

@clemsos clemsos requested a review from julien51 April 3, 2024 16:49
@clemsos
Copy link
Member Author

clemsos commented Apr 4, 2024

I am struggling to bridge the tokens on Base, because of gas limit/price that is not correct. We are running into out of gas error like here https://etherscan.io/tx/0x74b08c2475fb299b380fded66d4c285139c192e394468db8a4ad3f841a6ccbfa

It works on simulation with exactly same parameters but different gas settings, also works fine on Base Sepolia which mimicks the exact same token / bridge setup.

Apart from that its all ready

@julien51
Copy link
Member

julien51 commented Apr 4, 2024

Ok let me try to get do it as well!

@julien51
Copy link
Member

julien51 commented Apr 4, 2024

I used the official UIs to make some tests:

@julien51
Copy link
Member

julien51 commented Apr 4, 2024

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clemsos clemsos merged commit 0ae4d16 into master Apr 5, 2024
12 checks passed
@clemsos clemsos deleted the oeth-l2-bridge branch April 5, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants