New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(governance): bridge UDT on ARB and OP chains #13521
Conversation
smart-contracts/scripts/l2tokens.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing. This should go into governance
folder. We should be able to solve the sdk ethers5 issue with yarn resolutions
but I hadnt been able too so far ethereum-optimism/optimism#6295
smart-contracts/scripts/l2tokens.js
Outdated
const { ethers } = require('hardhat') | ||
const optimism = require('@eth-optimism/sdk') | ||
|
||
const L1_UDT_SEPOLIA = '0x0B26203E3DE7E680c9749CFa47b7ea37fEE7bd98' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get it from the networks package please?
smart-contracts/scripts/l2tokens.js
Outdated
async function main({ | ||
l1TokenAddress = L1_UDT_SEPOLIA, | ||
l2TokenAddress = L2_UDT_OP_SEPOLIA, | ||
l1ChainId = 11155111, // Sepolia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neworks package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. We dont have OP Sepolia in it. I was going to add Base Sepolia in networks package so maybe use that as default after
…to oeth-l2-bridge
It happens that UDT was already bridged on Arbitrum... https://arbiscan.io/address/0xd5d3aA404D7562d09a848F96a8a8d5D65977bF90#readProxyContract |
I am struggling to bridge the tokens on Base, because of gas limit/price that is not correct. We are running into out of gas error like here https://etherscan.io/tx/0x74b08c2475fb299b380fded66d4c285139c192e394468db8a4ad3f841a6ccbfa It works on simulation with exactly same parameters but different gas settings, also works fine on Base Sepolia which mimicks the exact same token / bridge setup. Apart from that its all ready |
Ok let me try to get do it as well! |
I used the official UIs to make some tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This adds a way to deploy a bridged token to Optimism chains, as well as a script to bridge some tokens.
Issues
Refs #11676
Checklist:
Release Note Draft Snippet