Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(governance): cleaner logs when pulling proxy admin address #13517

Merged
merged 5 commits into from Mar 25, 2024
Merged

feat(governance): cleaner logs when pulling proxy admin address #13517

merged 5 commits into from Mar 25, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Mar 25, 2024

Description

This improves the way the proxy admin is fetched (now directly from Unlock). Also some addition, reducing the annoying warning for deployer private key

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Mar 25, 2024
@clemsos clemsos requested a review from julien51 March 25, 2024 14:53
@clemsos clemsos marked this pull request as ready for review March 25, 2024 14:55
@clemsos clemsos mentioned this pull request Mar 25, 2024
Closed
@julien51 julien51 merged commit 97b13a0 into master Mar 25, 2024
12 checks passed
blahkheart pushed a commit to blahkheart/unlock that referenced this pull request Mar 26, 2024
@clemsos @blahkheart
feat(governance): cleaner logs when pulling proxy admin address (unlo…
e91f22f 
…ck-protocol#13517)

* cleaner logs when `DEPLOYER_PRIVATE_KEY` is not set

* get proxy admin address directly from unlock

* log admin+ multisig

* remove overkill marks

* log depoyer key env set correctly
blahkheart pushed a commit to blahkheart/unlock that referenced this pull request Mar 28, 2024
@clemsos @blahkheart
feat(governance): cleaner logs when pulling proxy admin address (unlo…
1fffe24 
…ck-protocol#13517)

* cleaner logs when `DEPLOYER_PRIVATE_KEY` is not set

* get proxy admin address directly from unlock

* log admin+ multisig

* remove overkill marks

* log depoyer key env set correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clemsos @julien51