fix(subgraph): fix ci deployment + better versioning #13500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemsos
commented
Mar 21, 2024
subgraph/bin/thegraph
Outdated
| .execSync('git rev-parse --short HEAD') | ||
| .toString() | ||
| .trim() | ||
| return `v${UNLOCK_LATEST_VERSION}-${PUBLICLOCK_LATEST_VERSION}-${gitSha}` |
There was a problem hiding this comment.
maybe commit hash alone is simpler as these version numbers are not pull from dynamically the contracts ?
There was a problem hiding this comment.
Yeah, in the end the unlock and public lock versions are not that useful anyway because the subgraoh supports them all at all times.
julien51
approved these changes
Mar 21, 2024
julien51
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a missing step on subgraph CI deployment, as weel as a better way to version the deployments.
Issues
Fixes #12867
Refs #
Checklist:
Release Note Draft Snippet