Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(governance): use listed signers when creating a multisig #13490

Merged
merged 7 commits into from Mar 20, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Mar 20, 2024

Description

This PR adds several things

  • uses the literal list of signers hardcoded in helper file as list of owners when creating a new safe.
  • move helpers to the /helpers folder (where they should be)
  • add a yarn hardhat safe:check command to check a single safe

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Mar 20, 2024
@clemsos clemsos requested a review from julien51 March 20, 2024 12:41
@clemsos clemsos merged commit a8e9799 into master Mar 20, 2024
12 checks passed
@clemsos clemsos deleted the multisig-create branch March 20, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants