Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add Gitcoin hook type #13482

Merged
merged 1 commit into from Mar 18, 2024
Merged

fix(types): add Gitcoin hook type #13482

merged 1 commit into from Mar 18, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Mar 18, 2024

Description

Add missing types for Gitcoin hook following #13436

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@clemsos clemsos requested a review from julien51 March 18, 2024 10:51
@cla-bot cla-bot bot added the cla-signed label Mar 18, 2024
@0xTxbi
Copy link
Contributor

0xTxbi commented Mar 18, 2024

hey @clemsos this was already introduced in this PR #13435

@julien51 julien51 merged commit 37c347e into master Mar 18, 2024
19 checks passed
@julien51 julien51 deleted the fix-gitcoin-hook-types branch March 18, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 approved these changes

Assignees
No one assigned
Labels
cla-signed run-all-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clemsos @0xTxbi @julien51