Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locksmith) trying to renew keys before they actually expire #13471

Merged
merged 2 commits into from Mar 19, 2024

Conversation

julien51
Copy link
Member

Description

The membership contract supports renewals before the actual expiration (starting at 90% of the duration to be precise). In order to avoid a "gap" in valid memberships, we now run the cronjob to renew so that it checks for keys that "will soon expire", rather than just the expired ones.

Issues

Fixes ##13363
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Copy link
Member

@clemsos clemsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julien51 julien51 merged commit 8fb443f into master Mar 19, 2024
12 checks passed
@julien51 julien51 deleted the worker-renewal-times branch March 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants