Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding value in swap call #13459

Merged
merged 10 commits into from Mar 13, 2024
Merged

adding value in swap call #13459

merged 10 commits into from Mar 13, 2024

Conversation

julien51
Copy link
Member

Description

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Mar 13, 2024
@julien51 julien51 requested a review from clemsos March 13, 2024 14:05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe get this from contracts package?

Copy link
Member

@clemsos clemsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julien51 julien51 merged commit 15c396e into master Mar 13, 2024
9 checks passed
@julien51 julien51 deleted the swap-and-hook-fix branch March 13, 2024 14:08
julien51 added a commit that referenced this pull request Mar 13, 2024
* adding value in swap call

* deployment addresses

* passing param at the right place

* contract file

* update contracts package

* cleanup

* remove missing networks

* using package

---------

Co-authored-by: Clément Renaud <clement+git@clementrenaud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants