Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Deploy #13446

Merged
merged 1 commit into from Mar 12, 2024
Merged

Production Deploy #13446

merged 1 commit into from Mar 12, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Mar 12, 2024

Production manual Deploy production-20240311-210336

This is a production deployment. Please treat with great caution!
This deploys the code from the master branch as of commit db666a6.

Reviewing this Pull Request's code is impractical; however, you are asked to check whether the current staging environment is stable and could be released. For this, follow these steps:

  • The staging environment has been fully deployed
  • This pull request has no conflicts with the production branch.
  • Go to http://staging.unlock-protocol.com/ and ensure that the website loads fine.

Creator Dashboard

  • Click on the "Go to your Dashboard" button and ensure that the dashboard loads as expected
  • Create a new Lock (using a test net is the best option) and wait for it to confirm with the right values
  • Update the price on this new lock or an older lock
  • Enable credit cards on one of your locks
  • Withdraw funds on one of the locks

Paywall

  • From the dashboard, open the Demo on one of your locks
  • Purchase a key to the lock using your crypto wallet
  • Make sure the content gets unlocked (is shown)
  • Refresh the page and make sure the content is still unlocked

Purchase URL

  • From the dashboard, create a purchase URL (redirect URL does not matter)
  • In the purchase URL, configure metadata collection to collect an email address, as well as at least one other of data
  • By using a recent lock, enable multiple purchases in the URL
  • Go through the checkout flow and ensure that it works as expected (data is collected for 2 users + and 2 keys are minted)

Verification

  • Add a separate address as a verifier
  • Create QR code for one of the valid NFT you own and check in using your phone or laptop camera
  • Check if metadata is displayed when you are a verifier and check-in is persistent from the members' page.

Payments methods

Credit Card flow for Unlock User accounts

  • Open the demo for a lock that has credit card enabled
  • Follow the steps to unlock using a credit card as a new user
  • Make sure unlocking works successfully
  • Connect to the keychain using your Unlock credentials
  • Ensure the key you just purchased is there

Swap & purchase

  • Update the currency for a lock (e.g. USDC) to enable swap & purchase
  • Open the demo for the lock with the updated currency
  • Make sure that swap & purchase is enabled as payment method
  • Use swap and purchase and make sure that unlocking works successfully

Custom credit card price

  • Open settings for a lock and go to payments.
  • Enable custom credit card and set a fixed price
  • Go through the checkout flow and ensure that the custom price correctly shows as the price for the lock
  • Make sure that purchase with custom price works successfully

@cla-bot cla-bot bot added the cla-signed label Mar 12, 2024
@julien51 julien51 requested a review from clemsos March 12, 2024 01:04
@julien51
Copy link
Member Author

julien51 commented Mar 12, 2024

a few extra things to check thoroughly:

  • scan des QR code + "check in"
  • creating Unlock accounts

@clemsos
Copy link
Member

clemsos commented Mar 12, 2024

Had a failure with credit card here with {message: "Price diverged by more than 3%. Aborting"} in the console (not visible to users though).

Minting worked with a fixed price though

@clemsos
Copy link
Member

clemsos commented Mar 12, 2024

The credit card total appears wrong with credit card at a fixed price (should be 7 + 2.90 + 0.70 = 10.60)

Screenshot 2024-03-12 at 11 06 07

@clemsos
Copy link
Member

clemsos commented Mar 12, 2024

Regarding metadata with tickets, if you buy several tickets with the same EOA address, should the metadata always be identical ?

What I did :

  • buy a ticket without metadata (token id 1)
  • create checkout w metadata
  • buy another ticket with metadata (token id 2)
  • result: both token id 1 and token id 2 has the same metadata

Is that expected ?

@julien51
Copy link
Member Author

Had a failure with credit card here with {message: "Price diverged by more than 3%. Aborting"} in the console (not visible to users though).

Ok, was there a lot of time between the time you started the process and the time you finished it?
Would you mind retrying it?

The credit card total appears wrong with credit card at a fixed price (should be 7 + 2.90 + 0.70 = 10.60)

Yeah it's missing the "minting fee (gas)" line. Can u please open an issue for this? I can add+hotfix today.

Is that expected ?

Yes because the metadata by default is attached to the owner address. That way it doesn't "leak" when the ticket is transferred.

@clemsos
Copy link
Member

clemsos commented Mar 12, 2024

Had a failure with credit card here with {message: "Price diverged by more than 3%. Aborting"} in the console (not visible to users though).

Minting worked with a fixed price though

ok that worked on a 3rd try. It should be Sepolia gas flucutations

@julien51 julien51 merged commit d039b7c into production Mar 12, 2024
24 checks passed
@julien51 julien51 deleted the production-20240311-210336 branch March 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants