Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(governance): Improve scripts to inspect and execute bridge txs #13419

Merged
merged 15 commits into from Apr 3, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Mar 5, 2024

Description

Adds README instructions and improved scripts to manipulate bridged txs and Zodiac delay module actions

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@clemsos clemsos requested a review from julien51 March 5, 2024 16:31
@cla-bot cla-bot bot added the cla-signed label Mar 5, 2024
@clemsos clemsos marked this pull request as ready for review March 8, 2024 08:45
@julien51
Copy link
Member

julien51 commented Mar 8, 2024

Does this include the script that "batches" all multisigs tx into a single one for the bridge?

@clemsos
Copy link
Member Author

clemsos commented Mar 13, 2024

Does this include the script that "batches" all multisigs tx into a single one for the bridge?

No, but the logic is present in the multisig approach we are using (using the safe-global libs). I think we can merge this one which is more about tooling and add the batched bridge txs in a separate PR (maybe for next cross chain proposal).

@clemsos clemsos force-pushed the improve-bridge-exec-scripts branch from 669a606 to 60cb756 Compare April 3, 2024 11:16
)
}

const connextSubgraphIds = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should mobe these to the networks file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we will need them someone else than here for now, so better to keep them here imo

@clemsos clemsos merged commit e9c694f into master Apr 3, 2024
7 checks passed
@clemsos clemsos deleted the improve-bridge-exec-scripts branch April 3, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants