building on stackage-nightly-2023-05-20 (ghc 9.4.5) #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2023 22:41
moved to ki 1.0.1.0 for greater build compatibility newly suppressed warnings in a few files - forall identifier - cases identifier (dunno how to suppress this which didn't show up as a warning) - type equality requires operators - deprecations
aryairani
force-pushed
the
stackage-nightly-2023-05-20
branch
from
60b76e8
to
3c6d061
Compare
aryairani
changed the title
ChrisPenner
reviewed
May 24, 2023
| @@ -1,6 +1,7 @@ | |||
| {-# LANGUAGE PatternSynonyms #-} | |||
| {-# LANGUAGE TupleSections #-} | |||
| {-# LANGUAGE ViewPatterns #-} | |||
| {-# OPTIONS_GHC -Wno-forall-identifier #-} | |||
There was a problem hiding this comment.
Maybe we could (carefully) s/forall/forAll as recommended by the manual instead? 😄 Looks like this will be come a non-optional error in a future release.
There was a problem hiding this comment.
Yeah I should've called it out better, this is just a temporary measure since it will become mandatory soon. forAll sounds like a good fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates us to ghc 9.4.5 via
resolver: nightly-2023-05-20Todo:
allow-newer: trueImplementation notes
'from filenames, for Windows buildsInteresting/controversial decisions
Could use better names than
ReferentG,SearchResult2etc.; though, the lack of better names is why these have been named with'for 5 years.Test coverage
Covered hopefully by existing tests
Loose ends
Dealing with all the newly suppressed warnings